Allow newer versions of template-haskell #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to compile with the newer versions of
template-haskell, without removing the ability to compile against older
versions if possible. Use the MIN_VERSION_template-haskell macro to
guard the changes. Add {-# LANGUAGE CPP #-} where necessary.
Exporting these previously internal helper functions allows the separation of the data constructor and the route instance. Yesod allows a similar separation. Without this, it can be tricky to avoid circular module dependencies. `mkRoute` and `mkRouteSub` are still exported as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also export
mkRouteData,mkRouteDispatchandmkRouteSubDispatchto allow separation of the data type from the routable instance.Bump the version while we're at it, as there are new features exposed.
I'm not so certain about the changes to the cabal file, feel free to make suggestions or edits.
Also, I suspect it would be better to bump the version in a separate commit. Just let me know.