fix: sort new enum field values #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byashimov
force-pushed
the
byashimov-sort-new-enum-field-values
branch
from
ad04b64 to
420d63b
Compare
The generator doesn't sort freshly added enum field values, it does so only on the diff operation. For example, [here](https://github.com/aiven/go-api-schemas/pull/300/files) the `log` value was added with the `log_level` field. And [here](https://github.com/aiven/go-api-schemas/pull/305/files) it was sorted by the differ. This causes [unnecessary diff](https://github.com/aiven/terraform-provider-aiven/pull/2164/files) in TF when the schema is updated.
byashimov
force-pushed
the
byashimov-sort-new-enum-field-values
branch
from
420d63b to
67d1ad8
Compare
vmyroslav
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator doesn't sort freshly added enum field values, it does so only on the diff operation.
For example, here the
logvalue was added with thelog_levelfield.And here it was sorted by the differ.
This causes unnecessary diff in TF when the schema is updated.