Skip to content

chore(updater): bump pkg/dist/*.yml (2025-02-21) #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

github-actions[bot]
Copy link
Contributor

automated changes by updater GitHub Actions workflow

Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid maximum value for an integer.

@rriski
Copy link
Contributor

rriski commented Feb 21, 2025

Invalid maximum value for an integer.

There are lots of these "2.147483647e+09", see e.g.

maximum: 2.147483647e+09

@byashimov
Copy link
Contributor

byashimov commented Feb 21, 2025

Invalid maximum value for an integer.

There are lots of these "2.147483647e+09", see e.g.

maximum: 2.147483647e+09

OK. It is just scientific notation of maxInt32:

fmt.Println(float64(2147483647) == float64(1<<31-1))
fmt.Println(int(float64(2147483647)))

true
2147483647

Additionally, we don't use min and max constraints in terraform.

@byashimov byashimov closed this Feb 21, 2025
@byashimov byashimov reopened this Feb 21, 2025
@byashimov byashimov enabled auto-merge (squash) February 21, 2025 08:43
@byashimov byashimov merged commit b455813 into main Feb 21, 2025
6 checks passed
@byashimov byashimov deleted the updater/2025-02-21-13449214315 branch February 21, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants