Skip to content

refactor: diff module #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2024
Merged

refactor: diff module #213

merged 1 commit into from
Oct 30, 2024

Conversation

byashimov
Copy link
Contributor

  • Refactors diff module
  • Sorts enum values to keep to ensure repeatable code
  • Sorts oneOf types to keep to ensure repeatable code
  • Compares oneOf by type instead the title
  • Removes goroutines
  • Removes global variables
  • Disables nlreturn and wsl
  • Enables liners for diff functions

@byashimov byashimov requested a review from a team as a code owner October 29, 2024 12:58
rriski
rriski previously approved these changes Oct 29, 2024
View reviewed changes
@byashimov byashimov force-pushed the byashimov-refactor-diff branch from 696d8c4 to cbb3ad4 Compare October 29, 2024 13:22
@byashimov byashimov force-pushed the byashimov-refactor-diff branch from cbb3ad4 to f7628d7 Compare October 29, 2024 13:22
@byashimov byashimov merged commit 269ea24 into main Oct 30, 2024
6 checks passed
@byashimov byashimov deleted the byashimov-refactor-diff branch October 30, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rriski rriski rriski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byashimov @rriski