-
Notifications
You must be signed in to change notification settings - Fork 4
feat: use new schema endpoint #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9dd2ed2
to
2e04f42
Compare
The new schema is a bit different, that makes a diff on several fields. Not critical for my taste. The code can be further simplified in separate PRs and cut down to a simple code snippet:
|
ed1db0c
to
4825cdd
Compare
d25b25c
to
4d07a5d
Compare
9034e40
to
c731c46
Compare
TF generation example https://github.com/aiven/terraform-provider-aiven/pull/1887/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, some questions / comments
Not available anymore.
- Downloads the schema from the new endpoint - Removes go client as a dependency
No network calls to measure
c318031
to
041cd41
Compare
041cd41
to
9c7e5fd
Compare
openapi-uc.json
schema support