Skip to content

feat: use new schema endpoint #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 8, 2024
Merged

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Oct 17, 2024

  • Removes influxdb and autoscaler integration (not available)
  • Adds new openapi-uc.json schema support
  • Uses old schemas for removed schemas (like influxdb)
  • Removes go client dependency, uses curl instead
  • Removes goroutine usage. Still runs under 1 sec
  • Removes MeasureExecutionTime, nothing to measure there

@byashimov byashimov requested a review from a team as a code owner October 17, 2024 22:47
@byashimov byashimov force-pushed the byashimov-use-new-schema-endpoint branch from 9dd2ed2 to 2e04f42 Compare October 17, 2024 22:49
@byashimov
Copy link
Contributor Author

byashimov commented Oct 17, 2024

The new schema is a bit different, that makes a diff on several fields. Not critical for my taste. The code can be further simplified in separate PRs and cut down to a simple code snippet:

  • cobra is an overkill
  • logger is a global object, which even causes false-positive linting issues
  • other global variables
  • lots of one-line functions
  • etc

@byashimov byashimov force-pushed the byashimov-use-new-schema-endpoint branch from ed1db0c to 4825cdd Compare October 22, 2024 12:56
@byashimov byashimov marked this pull request as draft October 30, 2024 09:47
@byashimov byashimov force-pushed the byashimov-use-new-schema-endpoint branch 3 times, most recently from d25b25c to 4d07a5d Compare November 4, 2024 10:53
@byashimov byashimov force-pushed the byashimov-use-new-schema-endpoint branch 2 times, most recently from 9034e40 to c731c46 Compare November 5, 2024 09:03
@byashimov
Copy link
Contributor Author

@byashimov byashimov marked this pull request as ready for review November 5, 2024 09:08
rriski
rriski previously approved these changes Nov 5, 2024
Copy link
Contributor

@rriski rriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, some questions / comments

@byashimov byashimov requested a review from rriski November 6, 2024 08:17
@byashimov byashimov force-pushed the byashimov-use-new-schema-endpoint branch from c318031 to 041cd41 Compare November 8, 2024 08:13
@byashimov byashimov force-pushed the byashimov-use-new-schema-endpoint branch from 041cd41 to 9c7e5fd Compare November 8, 2024 08:15
@byashimov byashimov enabled auto-merge (squash) November 8, 2024 08:30
@byashimov byashimov merged commit 88e4ac6 into main Nov 8, 2024
6 checks passed
@byashimov byashimov deleted the byashimov-use-new-schema-endpoint branch November 8, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants