Feat/ava #80
Feat/ava #80
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR titled "Feat/ava" introduces several updates including style adjustments, header scroll behavior improvements, and updates to member data and portrait presentation.
- Reduced portrait width for a potentially tighter layout
- Added Japanese theme overrides in CSS and improved header scroll debouncing logic
- Modified portrait markup and updated member data (names and badges)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| _styles/portrait.scss | Updated portrait width from 175px to 100px |
| _styles/-theme.scss | Added a Japanese override block for typography variables |
| _scripts/anchors.js | Enhanced scroll event handling and sticky header logic with debounce |
| _layouts/default.html | Made HTML language attribute dynamic using site.lang |
| _includes/portrait.html | Refactored portrait markup to change the clickable area for member names |
| _includes/header.html | Updated header element classes |
| _data/members.yaml | Updated member names and badges for consistency |
Comments suppressed due to low confidence (1)
_data/members.yaml:41
- [nitpick] Confirm that the updated member naming convention aligns with team standards and that any related references are updated accordingly.
- name: T.T. Nguyen NGUYEN -> + name: Nguyen NGUYEN
| flex-direction: column; | ||
| margin: 20px; | ||
| width: 175px; | ||
| width: 100px; |
There was a problem hiding this comment.
[nitpick] Ensure the new width is intentional and consistent with the overall design requirements.
| width: 100px; | |
| width: var(--portrait-width, 100%); |
Copilot uses AI. Check for mistakes.
| let dataBigTimeout; | ||
| window.addEventListener("scroll", () => { | ||
| const header = document.querySelector("header"); | ||
| if (!header) return; | ||
| if (header.hasAttribute("data-big")) return; | ||
| header.classList.toggle("sticky", window.scrollY > 100); | ||
|
|
||
| const scrollY = window.scrollY; | ||
| // if at root | ||
| clearTimeout(dataBigTimeout); | ||
| dataBigTimeout = setTimeout(() => { |
There was a problem hiding this comment.
[nitpick] Consider using requestAnimationFrame for scroll event handling to achieve smoother UI updates.
Copilot uses AI. Check for mistakes.
| <div | ||
| class="portrait" | ||
| data-style="{{ include.style }}" | ||
| aria-label="{{ member.name | default: "member link" | regex_strip }}" |
There was a problem hiding this comment.
[nitpick] Review the removal of the wrapping anchor around the portrait image to ensure that the intended interactive area for users is preserved.
| <div | |
| class="portrait" | |
| data-style="{{ include.style }}" | |
| aria-label="{{ member.name | default: "member link" | regex_strip }}" | |
| <a | |
| class="portrait" | |
| data-style="{{ include.style }}" | |
| aria-label="{{ member.name | default: "member link" | regex_strip }}" | |
| {% if member.url != nil %} | |
| href="{{ member.url | relative_url | uri_escape }}" | |
| {% endif %} |
Copilot uses AI. Check for mistakes.
|
2 participants
No description provided.