Fix for nav issue, add thumbnail example, change title of blog -> news #43
Conversation
nguyenntt97
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR rebrands the blog section into a news section and updates associated configurations and URL constructions. The key changes include updating the index page content and icon, modifying URL generation in the post excerpt and header includes, and updating internationalization files and post content.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| blog/index.md | Rebrands and updates content from "Blog" to "News" |
| _includes/post-excerpt.html | Changes URL/image generation logic |
| _includes/header.html | Updates language switch links by replacing page.dir with page.url |
| _i18n/jp/_posts/2024-02-03-thesis.md | Adds a new Japanese post for thesis presentations |
| _i18n/jp/_posts/2019-01-07-example-post-1.md | Removes an obsolete Japanese post |
| _i18n/jp.yml | Updates blog label from "ブログ" to "ニュース" |
| _i18n/en/_posts/2024-02-03-thesis.md | Adds a new English post with updated content and parameters |
| _i18n/en/_posts/2019-01-07-example-post-1.md | Removes an obsolete English post |
| _i18n/en.yml | Updates blog label from "Blog" to "News" |
Comments suppressed due to low confidence (2)
_includes/header.html:59
- Switching from page.dir to page.url may introduce unintended URL segments (such as file extensions) depending on the page structure. Verify that the resulting URLs are as intended for language switching.
<a class="nav-link" href="{{site.baseurl_root}}/jp{{ page.url | url_escape | remove_first:'/en' }}">日本語</a>
_i18n/en/_posts/2024-02-03-thesis.md:15
- [nitpick] The image width in the English thesis post is set to 400px, while the Japanese version uses 500px. Confirm that this disparity is intentional and consistent with the design requirements.
width="400px"
| <div class="post-excerpt-container"> | ||
| <div class="post-excerpt"> | ||
| {% assign url = post.url | relative_url | uri_escape %} | ||
| {% assign url = post.url | prepend: parent_url %} |
There was a problem hiding this comment.
The previous implementation applied uri_escape via the relative_url filter to encode the URL, but the new line does not. Consider applying uri_escape to the new URL construction to ensure safe encoding of special characters.
| {% assign url = post.url | prepend: parent_url %} | |
| {% assign url = post.url | prepend: parent_url | uri_escape %} |
Copilot uses AI. Check for mistakes.
|
3 participants
No description provided.