[readme] update blocks 16.1 #2513
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 18, 2021
| @@ -2144,8 +2144,8 @@ Other Style Guides | |||
|
|
|||
| ## Blocks | |||
|
|
|||
| <a name="blocks--braces"></a><a name="16.1"></a> | |||
There was a problem hiding this comment.
existing numbered links must never be removed; URLs must work forever.
| <a name="blocks--braces"></a><a name="16.1"></a> | ||
| - [16.1](#blocks--braces) Use braces with all multiline blocks. eslint: [`nonblock-statement-body-position`](https://eslint.org/docs/rules/nonblock-statement-body-position) | ||
| <a name="blocks--braces"></a> | ||
| - [16.1](#blocks--braces) Use braces with `if`, `else`, `while`, `do-while`, and `for` statements when writing multiline blocks. eslint: [`nonblock-statement-body-position`](https://eslint.org/docs/rules/nonblock-statement-body-position) |
There was a problem hiding this comment.
That's because function bodies aren't a block, they're a function body.
The eslint rule doesn't ever have to cover the entirety of the guide section - the guide is the source of truth, and the guide applies to all blocks.
There was a problem hiding this comment.
ok, got the point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gone through the eslint:
nonblock-statement-body-positiondocumentation where they didn't mention about thefunctionas block for this rule so, I removed the function example and clearly mention the block statements on which this rule implies.