Skip to content

Improve SwiftUIWrapperView performance #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Improve SwiftUIWrapperView performance #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Sources/Public/ItemViews/SwiftUIWrapperView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public final class SwiftUIWrapperView<Content: View>: UIView {

public init(contentAndID: ContentAndID) {
self.contentAndID = contentAndID
hostingController = UIHostingController(rootView: AnyView(contentAndID.content))
hostingController = UIHostingController(rootView: contentAndID.content)
hostingController._disableSafeArea = true

super.init(frame: .zero)
Expand Down Expand Up @@ -59,7 +59,9 @@ public final class SwiftUIWrapperView<Content: View>: UIView {
public override var isHidden: Bool {
didSet {
if isHidden {
hostingController.rootView = AnyView(EmptyView())
hostingControllerView.removeFromSuperview()
} else {
addSubview(hostingControllerView)
}
}
}
Expand Down Expand Up @@ -99,14 +101,14 @@ public final class SwiftUIWrapperView<Content: View>: UIView {

fileprivate var contentAndID: ContentAndID {
didSet {
hostingController.rootView = AnyView(contentAndID.content)
hostingController.rootView = contentAndID.content
configureGestureRecognizers()
}
}

// MARK: Private

private let hostingController: UIHostingController<AnyView>
private let hostingController: UIHostingController<Content>

private var hostingControllerView: UIView {
hostingController.view
Expand Down