Skip to content

Updated build system, github workflow, and switched to uv #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 4, 2025

Conversation

CQargi
Copy link
Contributor

@CQargi CQargi commented Jul 4, 2025

  • .python_version is removed: The tests workflow was failing because the python version was fixed to 3.9.9 in .python_version file while the workflow was trying to use 3.10.
  • Switched to uv and updated the build system to setuptools: poetry build was causing issues with newer versions of python, so switching to setuptools and uv seemed to be the easiest fix.
  • Updated test workflow: to use uv and run the tests with python 3.11 and 3.12
  • Updated .gitignore: With the recommended python gitignore in here: https://github.com/github/gitignore
  • Fixed some linting issues

Copy link
Contributor

@Pseudomanifold Pseudomanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great PR!

I agree with all the changes except the .gitignore. The list of things that your PR adds to that file is way too large and not pertinent to the project. For instance, we are not using any Django components at the moment, so there is no need to ignore them. Furthermore, your changes remove directories like /data/, which should never be added to the repo.

Can you please amend the PR accordingly?

@CQargi
Copy link
Contributor Author

CQargi commented Jul 4, 2025

Thanks for this great PR!

I agree with all the changes except the .gitignore. The list of things that your PR adds to that file is way too large and not pertinent to the project. For instance, we are not using any Django components at the moment, so there is no need to ignore them. Furthermore, your changes remove directories like /data/, which should never be added to the repo.

Can you please amend the PR accordingly?

Done. Sorry, I was being lazy and just copy pasted it. Now, it is cleaned up.

Copy link
Contributor

@Pseudomanifold Pseudomanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, thanks so much!

@Pseudomanifold Pseudomanifold merged commit ee29946 into aidos-lab:main Jul 4, 2025
2 checks passed
@Pseudomanifold
Copy link
Contributor

Thanks for your wonderful contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants