Skip to content

toml fix & deprecated object renamed #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

Roman223
Copy link
Contributor

@Roman223 Roman223 commented Apr 10, 2025

Solving issue #43

@Roman223
Copy link
Contributor Author

Please consider that perhaps this can break poetry build process. I've tested this only for usage with pip install -e .

@Pseudomanifold Pseudomanifold merged commit 9b22d9e into aidos-lab:main Apr 10, 2025
0 of 2 checks passed
@Pseudomanifold
Copy link
Contributor

Looks good to me—I will have to update poetry.lock, but maybe it would be better to go for another package manager.

@Roman223
Copy link
Contributor Author

@Pseudomanifold , have u managed to fix tests??

@Pseudomanifold
Copy link
Contributor

Not yet, seems to be a problem with the actions.

@Roman223
Copy link
Contributor Author

It turns out that problem is deeper.
According this, if poetry is not on 2.0.0 version, then [tool.poetry] and [project] cannot be used interchangeably.
But OP from issue #43 has version greater than 2... So, poetry core should be updated as well in toml.

After this I got:

-> % poetry check       
The "poetry.dev-dependencies" section is deprecated and will be removed in a future version. Use "poetry.group.dev.dependencies" instead.
Error: pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock` to fix the lock file.
Warning: The "poetry.dev-dependencies" section is deprecated and will be removed in a future version. Use "poetry.group.dev.dependencies" instead.
Warning: [tool.poetry.dependencies] is set but [project.dependencies] is not and 'dependencies' is not in [project.dynamic]. You should either migrate [tool.poetry.dependencies] to [project.dependencies] (if you do not need Poetry-specific features) or add [project.dependencies] in addition to [tool.poetry.dependencies] or add 'dependencies' to [project.dynamic].
Warning: [tool.poetry.dependencies.python] is set but [project.requires-python] is not set and 'requires-python' is not in [project.dynamic].

And unfortunately, in order to use both pip and poetry dependencies block should be duplicated.

[project]
<...>
dependencies = [
        'matplotlib>=3.5.0',
        'giotto-ph>=0.2.0',
        'torch>=1.12.0',
        'gudhi>=3.4.1',
        'POT>=0.9.0',
]

[tool.poetry.dependencies]
python = ">=3.9"
matplotlib = "^3.5.0"
giotto-ph = "^0.2.0"
torch = ">=1.12.0"
gudhi = "^3.4.1"
POT = "^0.9.0"

But you can safely ignore the warnings; only some features from Poetry might not work.

I've made another fix. Such a mess... I have to add this to my library.

@Roman223 Roman223 mentioned this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants