tooling updates #251
Merged
tooling updates #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easier to pass the full JSON to the agent if it needs tx details, less confusion on which tool to use
We have it in the DB but allows us to look up any mission on-chain.
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up unused tooling modules, harmonizes DAO action proposal tool names, and adds missing contract tooling.
- Removed legacy and unused DAO extension tools (timed vault, payments/invoices, onchain messaging, core proposals, Stacks transaction status)
- Updated
tools_factory.pymappings: renamed keys for consistency and removed deprecated imports - Incremented submodule reference for
agent-tools-ts
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/transactions.py | Deleted the obsolete StacksTransactionStatusTool and its schema |
| tools/tools_factory.py | Removed old imports, renamed mapping keys to align with new tooling |
| tools/dao_ext_timed_vault.py | Completely removed timed vault extension (cleaning up unused code) |
| tools/dao_ext_payments_invoices.py | Removed payments & invoices extension |
| tools/dao_ext_onchain_messaging.py | Removed onchain messaging extension |
| tools/dao_ext_core_proposals.py | Removed core proposals extension |
| agent-tools-ts | Updated subproject commit |
Comments suppressed due to low confidence (4)
tools/tools_factory.py:121
- [nitpick] The key
dao_propose_action_send_messagebreaks thedao_action_*prefix pattern used by the other DAO action tools; consider renaming todao_action_propose_send_message.
"dao_propose_action_send_message": ProposeActionSendMessageTool(wallet_id),
tools/tools_factory.py:120
- [nitpick] The key
dao_charter_get_current_charteris redundant (charterappears twice); consider usingdao_charter_get_currentfor consistency.
"dao_charter_get_current_charter": GetCurrentDaoCharterTool(wallet_id),
tools/dao_ext_timed_vault.py:1
- Entire timed vault module was removed; ensure that any related unit tests or references are also cleaned up or updated to prevent broken test runs.
from typing import Any, Dict, Optional, Type
tools/transactions.py:7
- With the removal of
StacksTransactionStatusTool, verify that no residual calls or documentation still reference this tool.
-class StacksTransactionStatusTool(BaseTool):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unused, add what's missing