Доступ к id загруженных файлов + Исправление сохранения внутренних сообщений Spring AI в ChatResponseMetadata #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ледующего доступа к ним Signed-off-by: Linar Abzaltdinov <abzaltdinov@gmail.com>
* Исправление сохранения внутренних сообзений Spring AI в ChatResponseMetadata Signed-off-by: Linar Abzaltdinov <abzaltdinov@gmail.com>
a-simeshin
reviewed
Jun 20, 2025
| */ | ||
| private List<Message> uploadMedia(List<Message> messages) { | ||
| return messages.stream() | ||
| .map(message -> { |
There was a problem hiding this comment.
Смотрится страшненько, может вынесем в отдельный метод?
| return messages.stream() | ||
| .map(message -> { | ||
| if (message instanceof UserMessage userMessage | ||
| && !CollectionUtils.isEmpty(userMessage.getMedia())) { |
There was a problem hiding this comment.
Предлагаю разбить на два условия сразу с выходом return message;
| .map(message -> { | ||
| if (message instanceof UserMessage userMessage | ||
| && !CollectionUtils.isEmpty(userMessage.getMedia())) { | ||
| var mediaWithIds = userMessage.getMedia().stream() |
There was a problem hiding this comment.
Также предлагаю вынести в отдельный метод
|
|
||
| List<Message> messages = prompt.getInstructions(); | ||
|
|
||
| // ищем индекс последнего пользовательского сообщения, т.к. здесь могут быть сообщения из ChatMemory |
There was a problem hiding this comment.
Также лучше вынести в отдельный метод логику поиска и последнего сообщения также с условием типизации под UserMessage, так как ниже есть оптимистичный каст под него, что не очень хорошо
There was a problem hiding this comment.
логику могу вынести, ок - но результатам метода будет индекс, int.
мне в одном месте нужен индекс, а в другом уже объект UserMessage, от каста не избавлюсь
a-simeshin
approved these changes
Jun 20, 2025
Signed-off-by: Linar Abzaltdinov <abzaltdinov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.