feat: Add dangerous mode to avoid node version check #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampathBlam
commented
Apr 11, 2020
sampathBlam
commented
- Add a new flag --dangerous / -d
- If the flag is present, corona-cli avoids node js version check
- Removed the minimal param for init function in index.js as it was not used
- Added .vscode to gitignore
- Added content for -d in help section.
- Addresses Support for node.js versions below 12 #83
- Add a new flag --dangerous / -d - If the flag is present, corona-cli avoids node js version check - Removed the minimal param for init function in index.js as it was not used - Added .vscode to gitignore - Added content for -d in help section.
ahmadawais
requested changes
Apr 12, 2020
| (async () => { | ||
| // Init. | ||
| init(minimal); | ||
| init(dangerous); |
There was a problem hiding this comment.
This is wrong. You remove minimal option all together.
There was a problem hiding this comment.
@ahmadawais : Sorry I did not get you. minimal option is not used inside the init module at all. That is the reason I removed it from the call.
| module.exports = async dangerous => { | ||
| unhandledError(); | ||
| checkNode(`10`); | ||
| if (!dangerous) { |
There was a problem hiding this comment.
You didn't handle the case when dangerous-version flag is set.
There was a problem hiding this comment.
@ahmadawais : By default, dangerous is false. I have added the logic in such a way that checkNode is called only if dangerous flag is not set. If dangerous is set, it will not go inside the if block at all. Does it make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.