Skip to content

Some random improvements from recent sweeper work #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented May 2, 2024

No description provided.

Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than the 3.12 python stuff

@stdavis stdavis force-pushed the fix/improvements branch from e4d0199 to e422960 Compare May 2, 2024 22:58
@stdavis stdavis requested a review from jacobdadams May 2, 2024 22:58
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (59d8c6a) to head (e422960).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines            9         9           
=========================================
  Hits             9         9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdavis
Copy link
Member Author

stdavis commented May 2, 2024

I'm going to leave this for @jacobdadams's review. No rush.

Copy link
Member

@jacobdadams jacobdadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

@stdavis stdavis merged commit e4ef7c2 into main May 15, 2024
4 checks passed
@stdavis stdavis deleted the fix/improvements branch May 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants