Skip to content

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented May 13, 2025

includes some ugrc standardizations as well

@stdavis stdavis force-pushed the dev branch 2 times, most recently from 3e3715e to 89096b6 Compare May 13, 2025 19:02
steveoh
steveoh previously approved these changes May 13, 2025
@stdavis stdavis force-pushed the dev branch 7 times, most recently from 883b4ce to 5c4ab67 Compare May 14, 2025 18:37
@agrc agrc deleted a comment from ugrc-release-bot bot May 14, 2025
@agrc agrc deleted a comment from ugrc-release-bot bot May 14, 2025
@agrc agrc deleted a comment from ugrc-release-bot bot May 14, 2025
@agrc agrc deleted a comment from github-actions bot May 14, 2025
@ugrc-release-bot
Copy link
Contributor

/remind me to verify that this works in 1 minute

Warning

This is a test of the dev branch.

@agrc agrc deleted a comment from ugrc-release-bot bot May 14, 2025
@github-actions
Copy link

@ugrc-release-bot[bot] set a reminder for 2025-05-14

@stdavis
Copy link
Member Author

stdavis commented May 14, 2025

/remind me to check if this works in one hour

@github-actions
Copy link

@stdavis set a reminder for 2025-05-14

@ugrc-release-bot
Copy link
Contributor

/remind me to verify that this works in 1 minute

Warning

This is a test of the dev branch.

@github-actions
Copy link

@ugrc-release-bot[bot] set a reminder for 2025-05-14

@agrc agrc deleted a comment from github-actions bot May 14, 2025
@agrc agrc deleted a comment from ugrc-release-bot bot May 14, 2025
@agrc agrc deleted a comment from github-actions bot May 14, 2025
@agrc agrc deleted a comment from ugrc-release-bot bot May 14, 2025
@agrc agrc deleted a comment from ugrc-release-bot bot May 14, 2025
@agrc agrc deleted a comment from github-actions bot May 14, 2025
@stdavis stdavis marked this pull request as ready for review May 14, 2025 19:05
@stdavis stdavis enabled auto-merge (rebase) May 14, 2025 20:22
@stdavis
Copy link
Member Author

stdavis commented May 14, 2025

@steveoh I feel like this is close enough to get a review and merge. I'll try to update the sister action to search for PRs as well so that the integration test can make the full circle. However, even if it didn't we can see that it at least runs without errors.

I did compare the metadata from a recent porter issue with the one from this PR and it seems to be consistent:

current

<!-- bot: {"reminders":[{"id":1,"who":"stdavis","what":"continue with the hard delete","when":"2025-06-02T09:00:00.000Z"}]} -->

new

<!-- bot: {"reminders":[{"id":6,"who":"ugrc-release-bot[bot]","what":"verify that this works","when":"2025-05-14T18:59:33.721Z"}]} -->

@stdavis stdavis disabled auto-merge May 14, 2025 20:28
@stdavis stdavis enabled auto-merge (rebase) May 14, 2025 20:50
@agrc agrc deleted a comment from ugrc-release-bot bot May 14, 2025
@agrc agrc deleted a comment from github-actions bot May 14, 2025
@ugrc-release-bot
Copy link
Contributor

/remind me to verify that this works in 1 minute

Warning

This is a test of the dev branch.

@github-actions
Copy link

@ugrc-release-bot[bot] set a reminder for 2025-05-14

@stdavis stdavis merged commit 6eb9d4d into main May 15, 2025
11 checks passed
@stdavis stdavis deleted the dev branch May 15, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants