Promote Dev #239
Merged
Promote Dev #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is all done automatically via GH actions now.
plus, fix some imports and exports
There was a problem hiding this comment.
Pull Request Overview
This PR promotes development practices by migrating the codebase from CommonJS to ES modules, updating dependency versions, and switching from npm to pnpm along with a transition from Jest to Vitest for testing. Key changes include:
- Converting module exports/imports in utilities.js, index.js, and index.test.js.
- Updating package.json scripts/dependencies and ESLint configuration.
- Modifying CI workflows in .github/workflows/pull_request.yml to use pnpm.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| utilities.js | Migrates from require/module.exports to ES module syntax |
| package.json | Updates dependency versions and switches scripts to pnpm |
| index.test.js | Converts from CommonJS to ES module syntax and switches to Vitest for testing |
| index.js | Changes require statements to import and refactors actions core usage |
| eslint.config.js | Simplifies ESLint configuration using the new @ugrc/eslint-config export |
| README.md | Removes outdated package distribution instructions |
| .github/workflows/pull_request.yml | Updates workflow steps to use pnpm instead of npm |
steveoh
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for highlights