Skip to content

Conversation

@kausmeows
Copy link
Contributor

@kausmeows kausmeows commented May 15, 2025

Summary

House keeping:

  • For each of the model tests, ensure it works if only the minimal packages are installed. I.e. to prevent that we accidentally require packages for all users.

Run locally- sh scripts/model_tests_setup.sh <model_name> for example-

sh scripts/model_tests_setup.sh openai

image

image

(If applicable, issue number: #____)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Improvement
  • Model update
  • Other:

Checklist

  • Code complies with style guidelines
  • Ran format/validation scripts (./scripts/format.sh and ./scripts/validate.sh)
  • Self-review completed
  • Documentation updated (comments, docstrings)
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable)
  • Tested in clean environment
  • Tests added/updated (if applicable)

Additional Notes

Add any important context (deployment instructions, screenshots, security considerations, etc.)

@kausmeows kausmeows requested a review from a team as a code owner May 15, 2025 13:03
@linear
Copy link

linear bot commented May 15, 2025

@dirkbrnd dirkbrnd merged commit f398825 into main May 16, 2025
24 of 26 checks passed
@dirkbrnd dirkbrnd deleted the improvement-in-test_on_releaseyml-ag-3177 branch May 16, 2025 12:39
Mustafa-Esoofally pushed a commit that referenced this pull request Jun 4, 2025
…n release (#3208)

## Summary

House keeping:
- For each of the model tests, ensure it works if only the minimal
packages are installed. I.e. to prevent that we accidentally require
packages for all users.

Run locally- `sh scripts/model_tests_setup.sh <model_name>` for example-

`sh scripts/model_tests_setup.sh openai`


![image](https://github.com/user-attachments/assets/53ca58fe-1bb1-40f2-87fd-086055e9a5f9)


![image](https://github.com/user-attachments/assets/d58e454a-94a6-43f2-876b-7732faf07c44)


(If applicable, issue number: #____)

## Type of change

- [ ] Bug fix
- [ ] New feature
- [ ] Breaking change
- [x] Improvement
- [ ] Model update
- [ ] Other:

---

## Checklist

- [x] Code complies with style guidelines
- [x] Ran format/validation scripts (`./scripts/format.sh` and
`./scripts/validate.sh`)
- [x] Self-review completed
- [ ] Documentation updated (comments, docstrings)
- [x] Examples and guides: Relevant cookbook examples have been included
or updated (if applicable)
- [x] Tested in clean environment
- [ ] Tests added/updated (if applicable)

---

## Additional Notes

Add any important context (deployment instructions, screenshots,
security considerations, etc.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants