Skip to content

Conversation

@ysolanky
Copy link
Contributor

Summary

Fix bug with citations being loaded from memory

(If applicable, issue number: #____)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Improvement
  • Model update
  • Other:

Checklist

  • Code complies with style guidelines
  • Ran format/validation scripts (./scripts/format.sh and ./scripts/validate.sh)
  • Self-review completed
  • Documentation updated (comments, docstrings)
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable)
  • Tested in clean environment
  • Tests added/updated (if applicable)

Additional Notes

Add any important context (deployment instructions, screenshots, security considerations, etc.)

@ysolanky ysolanky requested a review from a team as a code owner May 14, 2025 17:31
@linear
Copy link

linear bot commented May 14, 2025

AG-3171 fix citations

@kausmeows kausmeows changed the title fix-citations-ag-3171 fix: citations-ag-3171 May 14, 2025
@0xRichardH
Copy link
Contributor

Hi @ysolanky, I wanted to bring to your attention another PR #3186
That might provide a better approach for resolving this issue. It updates the from_dict method to handle the citations deserialization problem, which aligns with how existing fields like messages, images, etc., already address the model_dump issue.

@ysolanky ysolanky closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants