-
Notifications
You must be signed in to change notification settings - Fork 260
Algebra property reexports #2851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Ah - this is failing, in part because I assumed that what I was calling |
Er, no. It's because we accepted the |
jamesmckinna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made (frankly unsatisfactory) suggestions as to how to rename things, otherwise I'd simply approve. This all looks like useful refactoring/filling in the hierarchy, but we do need to do something about these cancel lemmas...
| ; cancelʳ to +-cancelʳ | ||
| ; cancelˡ to +-cancelˡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest, in view of the clash between naming of cancel properties, that you perhaps make these
| ; cancelʳ to +-cancelʳ | |
| ; cancelˡ to +-cancelˡ | |
| ; cancelʳ to cancelʳ-+ | |
| ; cancelˡ to cancelˡ-+ |
ahead of trying to figure out a solution to his mess.
Shoutout to @JacquesCarette for input on this (the names come from agda-categories via Jacques and his students, I think).
| ; cancelˡ to +-cancelˡ | ||
| ; insertˡ to +-insertˡ | ||
| ; insertʳ to +-insertʳ | ||
| ; cancelᶜ to +-cancelᶜ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ; cancelᶜ to +-cancelᶜ | |
| ; cancelᶜ to cancelᶜ-+ |
for consistency!?
| ; cancelʳ to *-cancelʳ | ||
| ; cancelˡ to *-cancelˡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See below for the additive versions.
| ; cancelˡ to *-cancelˡ | ||
| ; insertˡ to *-insertˡ | ||
| ; insertʳ to *-insertʳ | ||
| ; cancelᶜ to *-cancelᶜ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
| ; *-cancelʳ | ||
| ; *-cancelˡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to a renaming block?
| ; *-cancelˡ | ||
| ; *-insertˡ | ||
| ; *-insertʳ | ||
| ; *-cancelᶜ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.?
|
Actually, I think it might be easier to simply not export the 'offending' names, on the basis that
Thoughts? |
JacquesCarette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, this is good. In practice, clearly there are all sorts of problems. Which require non-trivial thinking, which I can't do right now. But will come back to this when I can.
RingWithoutOneis aSemiringWithoutOneAlgebra.Properties.SemiringWithoutOne