Skip to content

fix: claude-code-review OIDC handshake for forked branches #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

fix: claude-code-review OIDC handshake for forked branches #2171

merged 1 commit into from
Oct 30, 2025
+68 −20

Conversation

@priyansh4320
Copy link
Collaborator

@priyansh4320 priyansh4320 commented Oct 29, 2025 •
edited
Loading

Why are these changes needed?

This PR solves the OIDC handshake bug by enforcing Github Token auth for Claude review on forked branches.
This PR also solves the Claude review hallucinations , by referenced review approach.

Related issue number

Checks

@joggrbot
Copy link

joggrbot bot commented Oct 29, 2025 •
edited
Loading

📝 Documentation Analysis

All docs are up to date! 🎉

✅ Latest commit analyzed: 46d888d | Powered by Joggr

This was linked to issues Oct 29, 2025
[Bug/Enhancement]: reference based review fro claude review #2173
Closed
[Bug]: Claude code review OIDC handshke failure onfforked branches #2172
Closed
randombet
randombet approved these changes Oct 29, 2025
View reviewed changes
Copy link
Collaborator

@randombet randombet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priyansh4320 priyansh4320 self-assigned this Oct 29, 2025
@priyansh4320 priyansh4320 added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit 00aa376 Oct 30, 2025
22 checks passed
@priyansh4320 priyansh4320 deleted the fix-claude-review-action-for-forked-branches branch October 30, 2025 12:57
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randombet randombet randombet approved these changes

@marklysze marklysze Awaiting requested review from marklysze

Assignees

@priyansh4320 priyansh4320

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug/Enhancement]: reference based review fro claude review [Bug]: Claude code review OIDC handshke failure onfforked branches

3 participants

@priyansh4320 @randombet