Replace duplicate logic with normalize_content and normalize_message_to_dict #2152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombet
changed the title
Codecov Report❌ Patch coverage is
... and 40 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Lancetnik
reviewed
Oct 20, 2025
|
|
||
| def test_normalize_content_with_string(): | ||
| """Test normalize_content with string input.""" | ||
| from autogen.agentchat.utils import normalize_content |
There was a problem hiding this comment.
Why do you import function in each test? Can we import it on top of the file?
Lancetnik
reviewed
Oct 20, 2025
| assert original_str == "Original string" | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
Please, remove manual-run block from the test file
Lancetnik
reviewed
Oct 20, 2025
There was a problem hiding this comment.
There are a lot of pretty same tests for each function. Can we group some of them to parametrized run?
@pytest.mark.parametrize(
("value", "expected"),
(
pytest.param("Hello world", "Hello world", id="regular string")
pytest.param("", "", id="emepty string")
pytest.param(None, "", id="none")
... # etc
)
)
def test_normalize_content(value: Any, expected: str) -> None:
assert normalize_content(value) == expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The content normalization pattern is repeated ~15+ times across the codebase. Extract this into a helper function to improve maintainability.
Locations: chat.py:136-138, conversable_agent.py:1082-1087, conversable_agent.py:3984-3987, group_tool_executor.py:208, enforcer.py (multiple), groupchat.py (multiple)
Related issue number
Checks