Added a timeout to pin_thread. #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pveentjer
force-pushed
the
fix/pin-thread-timeout
branch
from
1cb799a to
fecd011
Compare
vyazelenko
requested changes
Jun 19, 2025
| } | ||
|
|
||
|
|
scripts/remote-benchmarks-runner
Outdated
Comment on lines
192
to
206
| echo " | ||
| echo 'Pinning thread: ${thread_name}' | ||
| count=0 | ||
| tid=${tid_cmd} | ||
| while [ -z \"\${tid}\" ] && [ \${count} -lt 600 ]; do | ||
| sleep 0.1 | ||
| tid=${tid_cmd} | ||
| count=\$((count + 1)) | ||
| done | ||
| if [ -z \"\${tid}\" ]; then | ||
| echo 'Timeout: thread ${thread_name} not found after 60 seconds.' | ||
| exit 1 | ||
| fi | ||
| echo \"tid_${thread_name}='\${tid}'\" | ||
| taskset -p -c ${core} \${tid} | ||
| " |
There was a problem hiding this comment.
Does this need a set -e to support multi line?
There was a problem hiding this comment.
In the original code, the commands are not joined by a &&, but a ;. So you continue to the next no matter if the previous command fails. The current code has exactly the same semantics.
But I think setting 'set -e' would be better. There is no point continuing to the next line if the previous failed.
Also 2 cleanups were done to improve readability: 1) the string is placed over multiple lines 2) the variable containing the cmd to get the tid, is now renamed from tid to tid_cmd.
pveentjer
force-pushed
the
fix/pin-thread-timeout
branch
from
fecd011 to
32e3b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also 2 cleanups were done to improve readability: