Simplified the remote ipc/cluster/echo benchmark scripts. #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. What about the other scripts (MDC, Archive, Kafka, gRPC) that still use the old approach? |
|
My concern is about breaking stuff. The echo/ipc/cluster benchmarks I run frequently; so any problems are quickly found. |
Which means that we will have two different sets of scripts which will make code maintainability far worse. Therefore we should either do in all scripts or not do it at all. |
pveentjer
force-pushed
the
cleanup/remote-benchmark-scripts
branch
from
adb371f to
36c4be5
Compare
|
I have converted the rest as well. |
Instead of using a chain of commands using &&, the script is run with -e and the now there is a sequence of commands. The original code was pretty hard to understand and this should improve maintainability.
pveentjer
force-pushed
the
cleanup/remote-benchmark-scripts
branch
from
36c4be5 to
feb954f
Compare
pveentjer
added a commit
that referenced
this pull request
Jun 19, 2025
This reverts commit fbe7eb3.
vyazelenko
added a commit
that referenced
this pull request
Jun 19, 2025
This reverts commit fbe7eb3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a chain of commands using &&, the script is run with -e and the now there is a sequence of commands.
The original code was pretty hard to understand and this should improve maintainability.