-
Notifications
You must be signed in to change notification settings - Fork 208
[ENH] Added TemporalConvolutionalNetwork in aeon/networks #2933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left lots of comments here. Generally, you do not have to do keep doing the permute operations between channel and time axes. Networks model assumes always the input_shape parameters is (time, channels) and you do not have to keep doing the permutaiton internally, it is adding operations for no need.
Generally i would like to keep consistency with parameter names with other networks. Like n_filters
dilation_rate
aeon/networks/_tcn.py
Outdated
---------- | ||
num_inputs : int | ||
Number of input channels/features in the input sequence. | ||
num_channels : list of int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n_filters in docstring to follow the parameter name, no longer num_channels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n_filters name is failing, because aeon/networks/tests/test_all_networks.py
expects n_filters to be int and not list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to use n_blocks instead.
Hi @hadifawaz1999, Requested changes have been made. |
Reference Issues/PRs
Fixes #2931 .
What does this implement/fix? Explain your changes.
Introduce a robust and modular implementation of Temporal Convolutional Networks (TCN) for sequence modeling in
aeon.forecasting.deep_learning
.Does your contribution introduce a new dependency? If yes, which one?
N/A
Any other comments?
As of now, there is a weight normalization layer remaining. Need some clarifications before proceeding with that.
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access