Skip to content

[ENH] Make transformers inherit TransformerMixin and add CollectionToSeriesWrapper #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented May 17, 2025

  • Adds BaseTransformer inherits TransformerMixin, which removes the last of the now deprecated self._estimator_type attributes
  • Adds inverse transform tag to SeriesToCollectionBroadcaster as it has the function implemented, other small changes
    • There are issues with testing this currently, as the function does not return the same series/collection format. Not going to deal with this here
  • Adds a CollectionToSeriesWrapper as a counterpart to the broadcaster

@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package labels May 17, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review May 17, 2025 22:57
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as draft May 17, 2025 22:58
# Conflicts:
#	aeon/testing/estimator_checking/_yield_anomaly_detection_checks.py
# Conflicts:
#	aeon/anomaly_detection/base.py
#	aeon/testing/estimator_checking/_yield_anomaly_detection_checks.py
#	aeon/testing/testing_config.py
# Conflicts:
#	aeon/testing/testing_config.py
#	aeon/transformations/collection/compose/tests/test_pipeline.py
#	aeon/transformations/series/compose/tests/test_pipeline.py
@MatthewMiddlehurst MatthewMiddlehurst changed the title [ENH] Series transformer stuff [ENH] Make transformers inherit TransformerMixin and add CollectionToSeriesWrapper Jun 18, 2025
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review June 18, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant