-
Notifications
You must be signed in to change notification settings - Fork 207
[DOC] Improve visualization module documentation #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
Hi are there any issues with this? It is still a draft. |
There is a little change in |
Hi, @MatthewMiddlehurst I have made the changes, you can review it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for this. @TonyBagnall volunteered to review this in a recent meeting. One thing I noticed just at a glance is the distances figure is using too many series IMO, I think a single univariate series should be enough.
Okay, I will work on it. |
Hi, Matthew, I have made the changes. |
This is still incorrect, looks like the series length and number of channels are swapped. |
Hi, when I am running the below code snippet,
Since I'm selecting 5 rows and 10 timepoints for both Could this be due to how matplotlib.plot() interprets the 2D array (plotting one line per column)? |
Hi, @MatthewMiddlehurst, can you please take a look at the above message? |
Reference Issues/PRs
Fixes: #2580
What does this implement/fix? Explain your changes.
This PR addresses the following improvements in the Aeon documentation:
Adding New Notebooks:
Fixing Duplication:
examples.md
to correctly render theplotting_for_learning_tasks
notebook.Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access