Skip to content

CH-14472: Add eCPM Partitions and AdQuery #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CH-14472: Add eCPM Partitions and AdQuery #9

wants to merge 1 commit into from

Conversation

CrshOverride
Copy link
Contributor

No description provided.

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #14472: Change ecpmPartition to ecpmPartitions in Decision SDKs (and add deprecation mechanism).

karnowski
karnowski suggested changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@karnowski karnowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing anything that is marking the old singular ecpmPartition as deprecated. I thought the Swagger spec would use the Java deprecation system automagically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karnowski karnowski karnowski requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CrshOverride @karnowski