Skip to content

Add default paths to ignore for various languages in build matrix #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

felickz
Copy link
Contributor

@felickz felickz commented Apr 14, 2025

When applying a paths filter (as is done by this action), the paths-ignore defaults from the CodeQL extractors are NOT utilized. This will likely lead to unwanted detections and decreased performance. This PR aims to pull in some opinionated defaults to continue the journey for improved monorepo scanning.

Primary motivation for this PR was discovered during a performance evaluation

 [2025-04-11 14:37:52] [build-stdout] Done extracting /home/runner/work/sample-javascript-monorepo/sample-javascript-monorepo/packages/babel-cli/src/babel/sample.min.js (3 ms)

Changes to build-matrix.js (used by the changes and whole-repo action):

  • Enhancements to default path ignore patterns:
    • changes/build-matrix.js: Added default path ignore patterns for JavaScript/TypeScript, Java/Kotlin, Python, C#, Ruby, and C/C++ to improve the handling of unnecessary files during scans.
  • Application of default path ignore patterns:
    • changes/build-matrix.js: Implemented logic to apply default path ignore patterns if not explicitly provided in the project configuration. A warning is issued for languages with build-mode: none if no path ignore patterns are set.

Documentation update:

  • README.md: Updated the documentation to reflect the use of default path ignore patterns if not passed in the config input.

@felickz felickz marked this pull request as ready for review April 15, 2025 02:48
@felickz felickz requested a review from a team as a code owner April 15, 2025 02:48
@felickz felickz requested a review from aegilops April 15, 2025 02:48
felickz

This comment was marked as duplicate.

@aegilops aegilops merged commit a834a0a into main May 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants