Skip to content

feat/W-17623345/show type in composition oas #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

leandrogilcarrano
Copy link
Contributor

@leandrogilcarrano leandrogilcarrano commented Jan 29, 2025

The composition can also be used to delicate documentation or constraints of a subtype(s).
If a type is only composed of one referenced (sub)type (here productId), the parent type (here masterId) should display the only possible type (String).
Also, if a type is composed from multiple subtypes with the same type e.g. multiple String types with different constraints the type should be (String) and not Any.
Only if the type is composed from different types, we see Any as a valid fallback.

PRD: https://salesforce.quip.com/IrBzAjD9nEaF

DO NOT MERGE, waiting TD approve

@leandrogilcarrano leandrogilcarrano marked this pull request as ready for review January 30, 2025 12:55
@leandrogilcarrano leandrogilcarrano self-assigned this Jan 30, 2025
Copy link
Contributor

@alexpmule alexpmule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandrogilcarrano leandrogilcarrano merged commit 7440347 into main Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants