Skip to content

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Oct 16, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

snowystinger
snowystinger previously approved these changes Oct 16, 2025
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it's failing the tests as well?
Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()

@LFDanLu
Copy link
Member Author

LFDanLu commented Oct 16, 2025

oh lemme run against 18 locally, I assumed it was flaky

@rspbot
Copy link

rspbot commented Oct 17, 2025

Comment on lines +322 to +323
// eslint-disable-next-line @typescript-eslint/no-unused-vars
let {ref, ...itemProps} = item.props;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was tricky to figure out lol

@rspbot
Copy link

rspbot commented Oct 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants