-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: Clear button context provider on TagGroup items so they don't throw when in a CustomDialog #9051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…flict with parent contexts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it's failing the tests as well?
Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()
oh lemme run against 18 locally, I assumed it was flaky |
Build successful! 🎉 |
// eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
let {ref, ...itemProps} = item.props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was tricky to figure out lol
Build successful! 🎉 |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP