Skip to content

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Oct 16, 2025

This doesn't completely automate testing sheets but it just gathers a list of commits between two dates, that way you don't have to keep going back and forth between tabs to get the url for each commit. Then it writes it to a csv file which you can copy and then paste into a Google Sheets.

If we start using labels more, it'd be possible to sort them by RAC, V3, S2. Right now, it's just searching for keywords to categorize them but not every commit has these keywords.

In order for the commits to be pulled, the PRs need to marked with the "needs testing" label, that way we don't get every single PR.

It will use the info under "Test Instructions" in the PR description to fill out the instructions for the sheet. If the instructions are over 350 characters, it'll just say "go to pr". Now an actual reason (jk) to fill out this section!

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

run node scripts/getCommitsForTesting.js 2025-10-07 2025-10-18. you should new file created called 'output.csv'.

copy the results from 'output.csv' into google sheets. with everything highlighted, go to Data at the top, find "split text to columns", and then make sure you have separate by commas selected.

just make sure to get rid of output.csv when you're done

🧢 Your Project:

@rspbot
Copy link

rspbot commented Oct 16, 2025

@rspbot
Copy link

rspbot commented Oct 17, 2025

@yihuiliao yihuiliao marked this pull request as ready for review October 17, 2025 20:33
@yihuiliao yihuiliao changed the title chore: sorta automate testing sheet chore: get commits for testing Oct 17, 2025
reidbarber
reidbarber previously approved these changes Oct 17, 2025
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting Please verify that your date is correctly formatted when running node scripts/getCommitsForTesting.js 2025-10-07 2025-10-18, but then it continues to run properly.

Also it might be cool for the default to the last week if no arguments are provided.

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be best to have it pull all the commits for now until we get into the habit of tagging stuff with "needs testing"? Wonder if the PRs that shouldn't be tested are in the minority and thus easier to scan through from a full list rather than tag every PR that needs testing

@@ -0,0 +1,164 @@
const Octokit = require('@octokit/rest');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if we had a bot account with limited perms so we could avoid having to have everyone auth via cmd line. Ideally stored in secrets somewhere but maybe more trouble than it is worth unless we make an automated job to do this?

@rspbot
Copy link

rspbot commented Oct 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants