chore: Default to React 19 #8296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
| // setting the version to 'next' won't work due to a yarn 1 bug | ||
| let results = JSON.parse(await run('npm', ['view', 'react@next', '--json'])); | ||
| let version = results['dist-tags']['next']; | ||
| // setting the version to 'canary' won't work due to a yarn 1 bug |
There was a problem hiding this comment.
Yarn 1 bug? Still relevant?
There was a problem hiding this comment.
🤷 idk I didn't really want to change more than necessary
LFDanLu
approved these changes
May 23, 2025
reidbarber
approved these changes
May 23, 2025
wojtekmaj
reviewed
May 23, 2025
There was a problem hiding this comment.
Fun fact: you could also do:
npm pkg set resolutions.react=^18 resolutions.react-dom=^18
No custom scripts needed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to React 19 by default. Adds React 18 and canary tests to CI. Removes old storybook react builds in CI since we don't really use them. If needed, we can always build them locally. Prerequisite for RSC support for new website.