fix: Don't crash on unknown segment types in DateField #8284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
approved these changes
May 22, 2025
| // Node seems to convert everything to lowercase... | ||
| const TYPE_MAPPING = { | ||
| dayperiod: 'dayPeriod' | ||
| // Node seems to convert everything to lowercase... |
There was a problem hiding this comment.
Are you trying on node 22? I'm not seeing the issue in my local node environment
There was a problem hiding this comment.
this was there before. probably from some older version
LFDanLu
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8017
Some additional segment types are now returned by
Intl.DateTimeFormat#formatToParts, including'yearName'and'relatedYear'. These are mainly returned for the Chinese calendar (reference).Intl.DisplayNamesdoes not accept these segment types as inputs causing a crash. In addition the rest of our code does not support these and treats them as non-editable. This PR maps these segments to known types to avoid the crash.While we don't technically support the Chinese calendar in
@internationalized/dateand there is a bunch of other broken behavior at the moment, at least we don't crash on these segment types anymore.