Skip to content

fix: selected item scrolls into view in rac select story #8230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented May 13, 2025

Pretty sure this is the same issue I encountered with S2 Picker where we fixed the Virtualized RAC Select but S2 Picker still wasn't scrolling into view.

For details about this issue, see comment

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test Async Virtualized Collection Rendered Select story and make sure the selected item scrolls into view

🧢 Your Project:

@rspbot
Copy link

rspbot commented May 13, 2025

@LFDanLu LFDanLu added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit f9ea4ca May 14, 2025
32 checks passed
@LFDanLu LFDanLu deleted the combobox-selection branch May 14, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants