fix: Fix Table disabled state + Safari loadMore and scroll Combobox selected item into view when opening via click #8224
Conversation
…hen loading sentinel is provided
…fari position absolute/relative is not really well supported in Safari making the loading sentinel not scroll into view when scrolling the table
|
https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=948, can ignore the one failure, that is known and unrelated to this PR |
LFDanLu
changed the title
…via trigger click
LFDanLu
changed the title
There was a problem hiding this comment.
For now I'm skipping these tests until we do more testing and confirm if we want to focus + scroll the ComboBox selected item into view when opening the drop down via click. These tests originate from #1014 but I don't remember/can't find any reason why we don't want this behavior other than a214902. The NVDA problem should apply since we still clear focus when the input field is modified, but will test
There was a problem hiding this comment.
One potential weird point may be if you have a selected key and allowsCustomValue, where then if you backspace once the dropdown will open and an item will be focused, preventing a subsequent ENTER keypress from submitting your custom value
caught by chromatic
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP