[WIP] feat: Coachmark native popover #8095
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/@react-spectrum/s2/package.json # yarn.lock
# Conflicts: # packages/@react-spectrum/s2/package.json # yarn.lock
snowystinger
commented
Apr 15, 2025
| // Have to put the portal in a div with popover="manual" so it is also in the top layer and renders on top of the coachmark | ||
| // Note, this isn't great because I'm not honestly sure what would happen if the page scrolled or their is a parent which affects that placement, is | ||
| // top-layer unaffected by parent stacking context? scroll parent? | ||
| let internalContainer = useRef<HTMLDivElement>(null); |
There was a problem hiding this comment.
could remove this if we say menus aren't allowed in coachmarks, would need more examples and somewhere to put a 'X' button maybe?
## API Changes
@react-spectrum/s2/@react-spectrum/s2:UNSTABLE_CoachMark+UNSTABLE_CoachMark {
+ UNSAFE_className?: string
+ UNSAFE_style?: CSSProperties
+ aria-describedby?: string
+ aria-details?: string
+ aria-label?: string
+ aria-labelledby?: string
+ boundaryElement?: Element = document.body
+ children: ReactNode
+ className?: string | ((PopoverRenderProps & {
+ defaultClassName: string | undefined
+})) => string
+ containerPadding?: number = 12
+ crossOffset?: number = 0
+ defaultOpen?: boolean
+ isOpen?: boolean
+ maxHeight?: number
+ offset?: number = 8
+ onOpenChange?: (boolean) => void
+ placement?: Placement = 'bottom'
+ shouldFlip?: boolean = true
+ shouldUpdatePosition?: boolean = true
+ slot?: string | null
+ style?: CSSProperties | ((PopoverRenderProps & {
+ defaultStyle: CSSProperties
+})) => CSSProperties | undefined
+ styles?: StylesProp
+}/@react-spectrum/s2:UNSTABLE_CoachMarkTrigger+UNSTABLE_CoachMarkTrigger {
+ children: ReactNode
+ isOpen?: boolean
+ onOpenChange?: (boolean) => void
+} |
snowystinger
commented
Apr 15, 2025
| {...props} | ||
| <div | ||
| popover="manual" | ||
| role="dialog" |
There was a problem hiding this comment.
dialog? alert dialog? something else?
devongovett
reviewed
Apr 21, 2025
| } | ||
| } | ||
|
|
||
| @starting-style { |
There was a problem hiding this comment.
I think it should work to put this in the style macro as a condition?
let s = style({
translateY: {
default: 0,
'@starting-style': 4
}
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: