Skip to content

BREAKING-RELEASE: v3 [work in progress] #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

BREAKING-RELEASE: v3 [work in progress] #94

wants to merge 5 commits into from

Conversation

alexkli
Copy link
Contributor

@alexkli alexkli commented Apr 28, 2022

Do not merge yet! PR for milestone v3.

Collective changes for the next major version 3 including multiple breaking changes.

Includes PRs:

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #94 (9936914) into master (126d3c4) will decrease coverage by 0.12%.
The diff coverage is 96.00%.

❗ Current head 9936914 differs from pull request most recent head 468e52d. Consider uploading reports for the commit 468e52d to get more accurate results

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   98.87%   98.75%   -0.13%     
==========================================
  Files           1        1              
  Lines          89       80       -9     
==========================================
- Hits           88       79       -9     
  Misses          1        1              
Impacted Files Coverage Δ
index.js 98.75% <96.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126d3c4...468e52d. Read the comment docs.

@alexkli alexkli added this to the v3 milestone Apr 29, 2022
@adobe-bot
Copy link

adobe-bot commented Apr 29, 2022

🎉 Sizewatcher congratulates on the size improvement 📉:

   🎉 git -81.7% (736 kB => 134 kB)

node_modules -1.7% (74.8 MB => 73.5 MB)
Largest production node modules:
┌──────────────────┬────────────┬───────┐
│ name │ children │ size │
├──────────────────┼────────────┼───────┤
│ node-fetch │ 0 │ 0.14M │
├──────────────────┼────────────┼───────┤
│ abort-controller │ 0 │ 0.07M │
├──────────────────┼────────────┼───────┤
│ 2 modules │ 0 children │ 0.22M │
└──────────────────┴────────────┴───────┘
npm_package -1.7% (11.5 kB => 11.3 kB)
Package contents:
📦  @adobe/node-fetch-retry@2.2.0
=== Tarball Contents ===
850B .releaserc.json
3.2kB CODE_OF_CONDUCT.md
171B COPYRIGHT
11.3kB LICENSE
7.2kB README.md
555B index.d.ts
11.2kB index.js
1.1kB package.json
=== Tarball Details ===
name: @adobe/node-fetch-retry
version: 2.2.0
filename: @adobe/node-fetch-retry-2.2.0.tgz
package size: 11.3 kB
unpacked size: 35.7 kB
shasum: e6907c8fa66d798bed89d5a17950b41f18cf51fe
integrity: sha512-3CXC3jPn+XHKk[...]xdrJqlerV3IBQ==
total files: 8
Notes
  • PR branch: version3 @ aecd420
  • Base branch: master
  • Sizewatcher v1.2.1
  • Effective Configuration:
limits:
  fail: 100%
  warn: 30%
  ok: '-10%'
report:
  githubComment: true
  githubStatus: false
comparators: {}

jdelbick and others added 3 commits May 5, 2022 14:29
* retry on all error by default

* update doc

* requested changes
Co-authored-by: tmathern <60901087+tmathern@users.noreply.github.com>
@alexkli alexkli changed the title v3 [work in progress] BREAKING-RELEASE: v3 [work in progress] May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants