fix: Use Web Crypto compatible function for nonce generation - v2 #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 3914 3923 +9
=========================================
+ Hits 3914 3923 +9 ☔ View full report in Codecov by Sentry. |
tripodsan
reviewed
Feb 13, 2025
Comment on lines
+507
to
515
| beforeEach(() => { | ||
| uuidIdx = 0; | ||
| // eslint-disable-next-line no-plusplus | ||
| cryptoImpl.randomUUID = () => uuids[uuidIdx++]; | ||
| }); | ||
|
|
||
| it('renders document with many image references quickly', async () => { | ||
| await testRender('gt-many-refs'); | ||
| afterEach(() => { | ||
| cryptoImpl.randomUUID = originalRandomUUID; | ||
| }); |
There was a problem hiding this comment.
I like this better than esmock...
There was a problem hiding this comment.
Let's discuss here: #817 (comment)
Yes, the v2 is simply because randomUUID is easier to mock, but makes the implementation of the actual nonce generation a little more complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently trying to serve a page with nonce CSP results in
500in cloudflare:Worker: x-error: crypto_worker_default2.randomBytes is not a functionDeployed the fix and tested in Cloudflare: