fix: return columns as well #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+45
to
+47
| if (dataStruct.columns) { | ||
| ret.columns = dataStruct.columns; | ||
| } |
There was a problem hiding this comment.
funnily, the else case is not reported as missing in coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 3651 3655 +4
=========================================
+ Hits 3651 3655 +4 ☔ View full report in Codecov by Sentry. |
tripodsan
approved these changes
Jan 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
## [6.17.6](v6.17.5...v6.17.6) (2025-01-07) ### Bug Fixes * return columns as well ([#785](#785)) ([691314e](691314e))
|
🎉 This PR is included in version 6.17.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dominique-pfister
added a commit
that referenced
this pull request
Jan 7, 2025
dominique-pfister
added a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #784