-
Notifications
You must be signed in to change notification settings - Fork 17
add numeric icon feature #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkuntze
wants to merge
9
commits into
main
Choose a base branch
from
numeric-icon-names
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+217
−28
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c22899a
add numeric icon feature
dkuntze 6e4b6d7
augment regex to exclude a few more possibilities
dkuntze 0dcd4f6
fix test
dkuntze d31c526
two pass icon validation + tests
dkuntze 111cbf8
more tests and made the tests less expensive
dkuntze d85438c
icons named 'icon'
dkuntze e2fab3b
chore: add test
tripodsan 33ebd92
enhanced tests, upgraded logic to a state machine
dkuntze 19e2085
remove
dkuntze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,25 @@ | ||
<main> | ||
<div> | ||
<h1 id="icons">Icons</h1> | ||
<p>Hello <span class="icon icon-button"></span></p> | ||
<p>Hello <span class="icon icon-red"></span> banner.</p> | ||
<p>Hello <span class="icon icon-check"></span> mark.</p> | ||
<p>Hello<span class="icon icon-button"></span></p> | ||
<p>Hello <span class="icon icon-red"></span>banner.</p> | ||
<p>Hello <span class="icon icon-check"></span>mark.</p> | ||
<p>Team<span class="icon icon-rocket"></span>blasting off again.</p> | ||
<p>This is a <span class="icon icon-a-10-check"></span>that should work</p> | ||
<p>number check<span class="icon icon-1-check"></span></p> | ||
<p>number check<span class="icon icon-two-2-check"></span></p> | ||
<p>number check<span class="icon icon-three-3-check"></span></p> | ||
<p>number check<span class="icon icon-four4check"></span></p> | ||
<p>number check<span class="icon icon-5-check"></span></p> | ||
<p>number check<span class="icon icon-six-6000-check"></span></p> | ||
<p>number check<span class="icon icon-seven7000check"></span></p> | ||
<p>number check<span class="icon icon-8000check"></span></p> | ||
<p>number check<span class="icon icon-nine9000"></span></p> | ||
<p>number check<span class="icon icon-ten-10000"></span></p> | ||
<p>number check<span class="icon icon-eleven-11"></span></p> | ||
<p>number check<span class="icon icon-twelve-v1"></span></p> | ||
<p>icon named<span class="icon icon-icon"></span></p> | ||
<p>for :foo:2 press the <span class="icon icon-button"></span> please.</p> | ||
<p>Regular text <span class="icon icon-button"></span>more text <span class="icon icon-rocket"></span>final text</p> | ||
</div> | ||
</main> | ||
</main> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.