metafix #738
Merged
metafix #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tripodsan
commented
Nov 7, 2024
| @@ -53,15 +53,14 @@ export class FileS3Loader { | |||
| if (!dir) { | |||
| throw Error(`unknown bucketId: ${bucketId}`); | |||
| } | |||
| // eslint-disable-next-line no-console | |||
| let fileName = key.split('/').pop(); | |||
| let fileName = key.split('/').slice(2).join('/'); | |||
There was a problem hiding this comment.
structured test content to include folders
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 3609 3612 +3
=========================================
+ Hits 3609 3612 +3 ☔ View full report in Codecov by Sentry. |
dominique-pfister
approved these changes
Nov 7, 2024
|
@tripodsan please do not merge this PR at least until Monday as we are still validating a few points |
this is only on helix5.... so you can test there. |
|
🎉 This PR is included in version 6.15.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #737