Skip to content

fix: set code and content surrogate keys for json 404 #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

tripodsan
Copy link
Contributor

fixes #688

Copy link

This PR will trigger a patch release when merged.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6e6bc37) to head (4f2e381).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #692   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         3593      3593           
=========================================
  Hits          3593      3593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tripodsan tripodsan merged commit 6a947a3 into main Sep 17, 2024
7 checks passed
@tripodsan tripodsan deleted the 404surrogate branch September 17, 2024 12:07
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
## [6.14.6](v6.14.5...v6.14.6) (2024-09-17)

### Bug Fixes

* set code and content surrogate keys for json 404 ([#692](#692)) ([6a947a3](6a947a3)), closes [#688](#688)
Copy link

🎉 This PR is included in version 6.14.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
## [5.12.6](v5.12.5...v5.12.6) (2024-09-25)

### Bug Fixes

* set code and content surrogate keys for json 404 ([#692](#692)) ([#698](#698)) ([d334099](d334099)), closes [#688](#688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A 404 from the json pipeline should get content- and code-based surrogate keys
2 participants