Skip to content

fix: rewrite meta image link #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: rewrite meta image link #615

merged 2 commits into from
Jun 10, 2024

Conversation

tripodsan
Copy link
Contributor

fixes #604

new behaviour:

  • absolute links to internal images (to hlx.page/hlx.live) are now rewritten to use the configured production host and include image optimizer parameters. eg:
+---------------------------------------------------------------------------------------------------+
| Metadata                                                                                          |
+------------------+--------------------------------------------------------------------------------+
| Image            | <https://main--helix-pages--adobe.hlx.page/images/meta/default-meta-image.png> |
+------------------+--------------------------------------------------------------------------------+

from:
<meta property="og:image" content="https://main--helix-pages--adobe.hlx.page/images/meta/default-meta-image.png">

to:
<meta property="og:image" content="https://example.com/images/meta/default-meta-image.png?width=1200&#x26;format=pjpg&#x26;optimize=medium">

Copy link

github-actions bot commented Jun 6, 2024

This PR will trigger a patch release when merged.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f3cffb1) to head (d5d1828).
Report is 1 commits behind head on 5.x.

Additional details and impacted files
@@            Coverage Diff            @@
##               5.x      #615   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         4420      4422    +2     
=========================================
+ Hits          4420      4422    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tripodsan tripodsan merged commit 08c0e25 into 5.x Jun 10, 2024
7 checks passed
@tripodsan tripodsan deleted the rewrite-metaurls branch June 10, 2024 09:17
github-actions bot pushed a commit that referenced this pull request Jun 10, 2024
## [5.11.2](v5.11.1...v5.11.2) (2024-06-10)

### Bug Fixes

* **deps:** update adobe fixes ([#619](#619)) ([077b214](077b214))
* rewrite meta image link ([#615](#615)) ([08c0e25](08c0e25)), closes [#604](#604)
Copy link

🎉 This PR is included in version 5.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

tripodsan added a commit that referenced this pull request Jun 10, 2024
tripodsan added a commit that referenced this pull request Jun 10, 2024
github-actions bot pushed a commit that referenced this pull request Jun 10, 2024
## [6.12.4](v6.12.3...v6.12.4) (2024-06-10)

### Bug Fixes

* rewrite meta image link ([#615](#615)) ([#620](#620)) ([132e591](132e591)), closes [#604](#604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants