remote_list: fetch it using HTTP/1.1 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful "Host" HTTP header comes from HTTP/1.1. Using it in a HTTP/1.0 context is not valid, despite it works well for both default URLs. Also disable HTTP/1.1 default keep-alive, otherwise read call dies in timeout. Signed-off-by: Anthony Loiseau <anthony@loiseau.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful "Host" HTTP header comes from HTTP/1.1. Using it in a HTTP/1.0 context is not valid on the paper, despite it works well for both default URLs (official and fallback github mirror). I think using HTTP/1.1 instead is saner and more likely to succeed on custom URLs.
This requires to explicitly reject keep-alive connections (default behavior starting from HTTP/1.1) , otherwise read call timeouts waiting the end of stream. Since the result HTTP request is a bit long, I made it multi-line.