Skip to content

Fix: updated updateItemCount to only count available children (fixes #218) #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Fix: updated updateItemCount to only count available children (fixes #218) #219

merged 1 commit into from
Jun 2, 2025

Conversation

guywillis
Copy link
Contributor

Fixes #218

Fix

  • Updated updateItemCount function to only count available children

@guywillis guywillis self-assigned this May 30, 2025
@guywillis guywillis added the bug label May 30, 2025
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jun 2, 2025
@oliverfoster oliverfoster merged commit b316e2c into master Jun 2, 2025
1 check passed
@oliverfoster oliverfoster deleted the issue/218 branch June 2, 2025 09:38
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jun 2, 2025
github-actions bot pushed a commit that referenced this pull request Jun 2, 2025
@semantic-release-bot
Chore(release): 7.3.1 [skip ci]
730e50e 
## [7.3.1](v7.3.0...v7.3.1) (2025-06-02)

### Fix

* Changed updateItemCount to only count available children (#219) ([b316e2c](b316e2c)), closes [#219](#219)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2025

🎉 This PR is included in version 7.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@lemmyadams lemmyadams lemmyadams approved these changes

@joe-allen-89 joe-allen-89 Awaiting requested review from joe-allen-89

Assignees

@guywillis guywillis

Labels
bug released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grouped menu item numbering fix with filtered siblings
4 participants
@guywillis @oliverfoster @cahirodoherty-learningpool @lemmyadams