Migrate-s3-boards #781
Merged
Migrate-s3-boards #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
S3 Firmware Migration branch is ready for review @brentru |
|
Fully tested @brentru, this is now ready for release once reviewed |
brentru
requested changes
Jul 24, 2025
Comment on lines
+156
to
+161
| for attempt in 1 2 3; do | ||
| echo "Attempt $attempt: Fetching tinyuf2 release info for board $BOARD_NAME" | ||
| API_RESPONSE=$(curl --silent --fail https://api.github.com/repos/adafruit/tinyuf2/releases/latest) | ||
| if [ $? -ne 0 ]; then | ||
| echo "Attempt $attempt: curl failed to fetch release info." | ||
| if [ "$attempt" -eq 3 ]; then exit 1; else sleep $((60 + RANDOM % 40)); continue; fi |
There was a problem hiding this comment.
Could you remove the attempt loop? I'd rather the step fail so we can see what/why/where it failed and manually kick it
|
The fetch failure does happen often yes, and when it did then having a
2second retry just had an instant subsequent failure. I'd rather not know
about rate limit issues from GH, and instead only if it reliably fails.
The other solution may be to do authenticated token based requests, but felt higher risk.
…On Thu, 24 Jul 2025 at 15:57, Brent Rubell ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@tyeth <https://github.com/tyeth> I had some questions
------------------------------
In .github/workflows/build-clang-doxy.yml
<#781 (comment)>
:
> + for attempt in 1 2 3; do
+ echo "Attempt $attempt: Fetching tinyuf2 release info for board $BOARD_NAME"
+ API_RESPONSE=$(curl --silent --fail https://api.github.com/repos/adafruit/tinyuf2/releases/latest)
+ if [ $? -ne 0 ]; then
+ echo "Attempt $attempt: curl failed to fetch release info."
+ if [ "$attempt" -eq 3 ]; then exit 1; else sleep $((60 + RANDOM % 40)); continue; fi
Could you remove the attempt loop? I'd rather the step fail so we can see
what/why/where it failed and manually kick it
------------------------------
In .github/workflows/build-clang-doxy.yml
<#781 (comment)>
:
> + for attempt in 1 2 3; do
+ echo "Attempt $attempt: Fetching tinyuf2 release info for board $BOARD_NAME"
+ API_RESPONSE=$(curl --silent --fail https://api.github.com/repos/adafruit/tinyuf2/releases/latest)
+ if [ $? -ne 0 ]; then
+ echo "Attempt $attempt: curl failed to fetch release info."
+ if [ "$attempt" -eq 3 ]; then exit 1; else sleep $((60 + RANDOM % 40)); continue; fi
Does it fail often?
—
Reply to this email directly, view it on GitHub
<#781 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ4ZP64H7BZKSFMJLXWD3KDX6TAVCNFSM6AAAAACCDI7WBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANJSGAZTSMBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
brentru
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be merged until after S2 boards migration release, v107, then this PR tested first on each target:
"feather_esp32s3_4mbflash_2mbpsram",
"feather_esp32s3_reverse_tft",
"feather_esp32s3_tft",
"qtpy_esp32s3_n4r2",