Skip to content

Secrets Cleanup: P Part 2 #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Apr 9, 2025

@justmobilize
Copy link
Contributor Author

@FoamyGuy here's the last of the PyPortal ones.

Let me know if either of the 2 comments in #3004 should get added in here.

There will only be 1 more PR after this for secret clean-up!

@justmobilize justmobilize marked this pull request as ready for review April 9, 2025 17:22
@FoamyGuy
Copy link
Collaborator

FoamyGuy commented Apr 9, 2025

I took care of the rsa_private_key refactor and aio username / key in the settings file in a commit before merging the part 1 PR.

Can you correct the spelling mistake that Dan mentioned in this one please though? celcius -> celsius in PyPortalAlarmClock. I'll update the learn guide page with the correct spelling when I work through this new list.

- fix typos celcius to celsius
@justmobilize
Copy link
Contributor Author

@FoamyGuy fixed the typos (all of them). The others are all in comments and so don't need to be updated anywhere

@FoamyGuy
Copy link
Collaborator

Am about half way thru these, will pick up on them tomorrow

Need to return to after merge and update embed to settings.toml:
https://learn.adafruit.com/pyportal-voice-controlled-smart-switch-and-time-display/circuitpython-code

@FoamyGuy
Copy link
Collaborator

pyportal_weather_station/code.py is used here: https://learn.adafruit.com/pyportal-iot-weather-station/adafruit-io-setup. I've updated it for settings.toml.

Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me

@FoamyGuy FoamyGuy merged commit ef00664 into adafruit:main Apr 15, 2025
4 checks passed
@FoamyGuy
Copy link
Collaborator

I could not find any usage of the LastFM one either.

All page updates including the one mentioned above that needed an embed changed after the merge are complete.

@justmobilize justmobilize deleted the secrets-cleanup-p-part2 branch April 15, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants