Skip to content

Secrets Cleanup: L, M and O #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Secrets Cleanup: L, M and O #3001

merged 1 commit into from
Mar 31, 2025

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Mar 25, 2025 •
edited by FoamyGuy
Loading

justmobilize
justmobilize commented Mar 25, 2025
View reviewed changes
Macropad_2FA_TOTP/code.py
str_code = str(code % 10 ** digits)
while len(str_code) < digits:
str_code = '0' + str_code
otp_code = ((hmac_hash[offset] & 0x7f) << 24 |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reuse of code, so renamed

Macropad_2FA_TOTP/code.py
@@ -80,7 +76,9 @@
rtc_time.anchor_point = (0.0, 0.5)
rtc_time.anchored_position = (0, 59)

progress_bar = HorizontalProgressBar((68, 46), (55, 17), bar_color=0xFFFFFF, min_value=0, max_value=30)
progress_bar = HorizontalProgressBar(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting

MagTag/MagTag_Google_Calendar/authenticator.py
print("Credentials and tokens are kept in secrets.py, please add them there!")
raise
# Get WiFi details, ensure these are setup in settings.toml
ssid = getenv("CIRCUITPY_WIFI_SSID")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many MagTag examples import secrets, but don't always use them, but do use Network. So raising an error if the keys aren't there

@justmobilize justmobilize marked this pull request as ready for review March 25, 2025 22:36
@justmobilize
Copy link
Contributor Author

@FoamyGuy here's the next one!

justmobilize
justmobilize commented Mar 25, 2025
View reviewed changes
Macropad_2FA_TOTP/totp_keys.py
@@ -0,0 +1,22 @@
# SPDX-FileCopyrightText: 2021 Carter Nelson for Adafruit Industries
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed and updated from secrets.py per conversation on Discord

FoamyGuy
FoamyGuy approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FoamyGuy
Copy link
Collaborator

All guide pages are updated. I switched a handful of them from static uploaded file screenshots to the ones generated automatically.

@FoamyGuy FoamyGuy merged commit ef9f2cc into adafruit:main Mar 31, 2025
4 checks passed
@justmobilize justmobilize deleted the secrets-cleanup-l-o branch March 31, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justmobilize @FoamyGuy