Skip to content

Secrets Cleanup: F and I #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Mar 19, 2025

@justmobilize
Copy link
Contributor Author

@FoamyGuy here's the next one!

@justmobilize justmobilize marked this pull request as ready for review March 20, 2025 15:21
Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good to me.

@FoamyGuy
Copy link
Collaborator

Working through updating these on learn and I noticed that IoT_Environment_Sensors is further out of date I think. It's importing import adafruit_esp32spi.adafruit_esp32spi_requests here https://github.com/justmobilize/Adafruit_Learning_System_Guides/blob/906e10e48113400b41741077a425f857fed45707/IoT_Environment_Sensor/aio.py#L26 which doesn't seem to exist. I'm guessing that might be from before adafruit_requests existed.

@FoamyGuy
Copy link
Collaborator

iot neopixel sign is here: https://learn.adafruit.com/iot-led-sign/code

it doesn't have direct references to secrets.py. I did update it's files screenshot image though.

@FoamyGuy
Copy link
Collaborator

I created #3000 to track the environment sensor one needing further changes unrelated to the secrets.py effort.

@FoamyGuy FoamyGuy merged commit bedfa65 into adafruit:main Mar 25, 2025
4 checks passed
@justmobilize justmobilize deleted the secrets-cleanup-f-i branch March 31, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants